catdum200 0d348892e5 fix(protocol): accept BungeeCord-forwarded handshake addresses (#2774)
* fix(protocol): accept BungeeCord-forwarded handshake addresses

`SHandShake::read` bounded `server_address` at 255 characters, the limit a
vanilla client observes. `bungeecord_login`, however, expects that same field
to carry the host, the client's IP, its UUID and its signed profile properties
separated by NUL bytes, exactly as documented on that function. With
`ip_forward` enabled the signed properties alone run past a thousand
characters, so the read failed with "too large: string" before
`handle_handshake` ever ran: the connection state never advanced,
`server_address` stayed empty and the proxy login path could not be reached.

The same struct already writes this field with `write_string`, which bounds it
at `i16::MAX`, so the reader was stricter than the writer. Read it with that
same bound, as Spigot does.

Closes #1293

* test(proxy): cover a BungeeCord login from the wire up

Encodes a handshake the way BungeeCord puts it on the wire with
`ip_forward` enabled, decodes it with the real packet reader, and hands
the resulting address to `bungeecord_login`, asserting the forwarded IP,
the forwarded UUID and the signed skin all survive the trip.

Without the widened bound on `server_address` this fails inside
`SHandShake::read`, so `bungeecord_login` is never reached at all.
2026-08-05 08:59:48 +02:00
2026-07-30 12:55:41 +02:00
2026-08-04 10:38:27 +02:00
2026-07-24 12:31:57 +02:00
2026-08-03 21:16:07 +02:00
2025-03-29 13:25:37 +01:00
2025-05-10 12:46:42 +02:00
2026-07-26 10:25:13 +02:00
2026-08-04 10:38:27 +02:00
2026-08-04 10:38:27 +02:00
2025-08-11 20:45:55 +02:00
2024-12-04 11:37:41 +01:00

Pumpkin

CI Discord License: GPL

Pumpkin is a Minecraft server built entirely in Rust, offering a fast, efficient, and customizable experience. It prioritizes performance and player enjoyment while adhering to the core mechanics of the game.

Pumpkin Chunk Loading

Goals

  • Performance: Leveraging multi-threading for maximum speed and efficiency.
  • Compatibility: Supports the latest Java & Bedrock Minecraft server version while adhering to Vanilla game mechanics.
  • Security: Prioritizes security by preventing known security exploits.
  • Flexibility: Highly configurable, with the ability to disable unnecessary features.
  • Extensibility: Provides a foundation for plugin development.

Important

Pumpkin is currently under heavy development.

See what needs to be done before the 1.0.0 Release

Features

  • Configuration (toml)
  • Tracking: Protocol
    • Server Status/Ping
    • Encryption
    • Packet Compression
    • Java Edition
    • Bedrock Edition (W.I.P)
    • ...
  • Tracking: World
    • Player Tab-list
    • Scoreboard
    • World Loading
    • World Time
    • World Borders
    • World Saving
    • Lighting
    • Entity Spawning
    • Bossbar
    • Chunk Loading (Vanilla, Linear, Pump)
    • Chunk Generation
    • Chunk Saving (Vanilla, Linear, Pump)
    • Redstone
    • Liquid Physics
    • ...
  • Tracking: Player
    • Skins
    • Teleport
    • Movement
    • Animation
    • Inventory
    • Combat
    • Experience
    • Hunger
    • Off Hand
    • Advancements (W.I.P)
    • Eating
    • ...
  • Entities
    • Non-Living (Minecart, Eggs...) (W.I.P)
    • Entity Effects
    • Players
    • Mobs (W.I.P)
    • Animals (W.I.P)
    • Entity AI
    • Boss (W.I.P)
    • Villagers (W.I.P)
    • Entity Saving
  • Server
    • Plugins
    • Query
    • RCON
    • Inventories
    • Particles
    • Chat
    • Commands
    • Permissions
    • Translations
  • Proxy
    • Bungeecord
    • Velocity

How to run

See our Quick Start guide to get Pumpkin running.

Contributions

Contributions are welcome! See CONTRIBUTING.md

Docs

Pumpkin's documentation can be found at https://pumpkinmc.org/

Communication

Consider joining our Discord server to stay up-to-date on events, updates, and connect with other members.

Funding

If you want to fund me and help the project, check out the Donation Page.

Description
Languages
Rust 100%