majjo/Pumpkin
1
0
Fork 0
mirror of https://github.com/Pumpkin-MC/Pumpkin.git synced 2026-08-31 08:22:33 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix: allow snow layers to be placed on top of leaves (#2246)

Browse Source 
Snow placement checked is_side_solid (isSideSolidFullSquare / support
shape), which leaves override to be empty. Vanilla's SnowBlock#canPlaceAt
instead checks the snow_layer support tags and whether the block's
collision shape fully covers the top face — leaves have a full-cube
collision shape, so they should support snow layers.

Fixes #2218
This commit is contained in:
perplexinglysimple
2026-06-20 13:55:03 -06:00
committed by GitHub
parent 11380eb38a
commit e0ec4f9569
1 changed files with 22 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

25
pumpkin/src/block/blocks/snow.rs
View File

@@ -1,5 +1,6 @@
use pumpkin_data::block_properties::BlockProperties;
use pumpkin_data::{Block, BlockDirection, block_properties::SnowLikeProperties, item::Item};
use pumpkin_data::tag::Taggable;
use pumpkin_data::{Block, block_properties::SnowLikeProperties, item::Item, tag};
use pumpkin_macros::pumpkin_block;
use pumpkin_util::math::position::BlockPos;
use pumpkin_world::{
@@ -101,6 +102,24 @@ impl BlockBehaviour for LayeredSnowBlock {
}
fn can_place_at(block_accessor: &dyn BlockAccessor, position: &BlockPos) -> bool {
let state = block_accessor.get_block_state(&position.down());
state.is_side_solid(BlockDirection::Up)
let below_pos = position.down();
let (below_block, state) = block_accessor.get_block_and_state(&below_pos);
if below_block.has_tag(&tag::Block::MINECRAFT_CANNOT_SUPPORT_SNOW_LAYER) {
return false;
}
if below_block.has_tag(&tag::Block::MINECRAFT_SUPPORT_OVERRIDE_SNOW_LAYER) {
return true;
}
// Block.isFaceFullSquare(collisionShape, Direction.UP): the collision shape must fully cover
// the top face, e.g. leaves are not "side solid" but do support snow layers.
state.get_block_collision_shapes().any(|shape| {
shape.max.y >= 1.0
&& shape.min.x <= 0.0
&& shape.max.x >= 1.0
&& shape.min.z <= 0.0
&& shape.max.z >= 1.0
}) || (below_block == &Block::SNOW
&& SnowLikeProperties::from_state_id(state.id, below_block).layers == 8)
}