majjo/Pumpkin
1
0
Fork 0
mirror of https://github.com/Pumpkin-MC/Pumpkin.git synced 2026-08-30 20:14:23 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix(entity): mobs no longer burn at night (#2123)

Browse Source
This commit is contained in:
Giems
2026-05-20 11:24:39 +02:00
committed by GitHub
parent 6b7628962d
commit 4ad5b2ba03
1 changed files with 18 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

19
pumpkin/src/entity/mob/mod.rs
View File

@@ -78,6 +78,16 @@ pub struct MobEntity {
last_sent_head_yaw: AtomicU8,
}
/// Tick boundaries (both inclusive) when monsters do not burn in sunlight (26.1).
///
/// Sourced from `data/minecraft/timeline/day.json` — `monsters_burn` keyframes:
/// `value=false` at tick 12542 (dusk), `value=true` at tick 23460 (dawn).
///
/// TODO: Replace with `EnvironmentAttributes::MONSTERS_BURN` lookup once the
/// `EnvironmentAttributeSystem` is implemented in `pumpkin-data`.
const NIGHT_START: i64 = 12542;
const NIGHT_END: i64 = 23459;
impl MobEntity {
#[expect(dead_code)]
const AI_DISABLED_FLAG: u8 = 1;
@@ -299,7 +309,14 @@ impl MobEntity {
let world_arc = entity.world.load();
let world = world_arc.as_ref();
// TODO: gate behind EnvironmentAttributes::MONSTERS_BURN once implemented.
// Night boundary from data/minecraft/timeline/day.json — monsters_burn keyframes:
// value=false at tick 12542 (dusk), value=true at tick 23460 (dawn).
// TODO: read directly from EnvironmentAttributes::MONSTERS_BURN once implemented.
let day_time = world.get_time_of_day().await % 24000;
if (NIGHT_START..=NIGHT_END).contains(&day_time) {
return false;
}
// Vanilla: getLightLevelDependentMagicValue() — sky light at eye pos, scaled 0–1.
let eye_block_pos = entity.get_eye_pos();