From 896f24f5b613d97cd7a10fac4eed9fb8a1dccec0 Mon Sep 17 00:00:00 2001 From: Jagandeep Brar Date: Sat, 13 May 2023 13:14:17 -0400 Subject: [PATCH] chore(ci): automatically extract publisher and publisher name from signing certificate --- .github/workflows/build.yml | 2 -- .github/workflows/build_windows.yml | 8 +------- 2 files changed, 1 insertion(+), 9 deletions(-) diff --git a/.github/workflows/build.yml b/.github/workflows/build.yml index 5a506c43..310445bf 100644 --- a/.github/workflows/build.yml +++ b/.github/workflows/build.yml @@ -103,8 +103,6 @@ jobs: secrets: CODE_SIGNING_CERTIFICATE: ${{ secrets.CODE_SIGNING_CERTIFICATE }} CODE_SIGNING_PASSWORD: ${{ secrets.CODE_SIGNING_PASSWORD }} - CODE_SIGNING_PUBLISHER: ${{ secrets.CODE_SIGNING_PUBLISHER }} - CODE_SIGNING_PUBLISHER_NAME: ${{ secrets.CODE_SIGNING_PUBLISHER_NAME }} publish-android: name: Publish Android diff --git a/.github/workflows/build_windows.yml b/.github/workflows/build_windows.yml index ed80cb57..4f858345 100644 --- a/.github/workflows/build_windows.yml +++ b/.github/workflows/build_windows.yml @@ -7,10 +7,6 @@ on: required: true CODE_SIGNING_PASSWORD: required: true - CODE_SIGNING_PUBLISHER: - required: true - CODE_SIGNING_PUBLISHER_NAME: - required: true jobs: build-app-package: @@ -49,9 +45,7 @@ jobs: flutter pub run msix:create ` --certificate-password=${{ secrets.CODE_SIGNING_PASSWORD }} ` --certificate-path=${{ github.workspace }}/keys/codesigning.pfx ` - --output-path=${{ github.workspace }}/output ` - --publisher=${{ secrets.CODE_SIGNING_PUBLISHER }} ` - --publisher-display-name=${{ secrets.CODE_SIGNING_PUBLISHER_NAME }} + --output-path=${{ github.workspace }}/output - name: Upload Artifact uses: actions/upload-artifact@v3