Commit Graph

14 Commits

Author SHA1 Message Date
Kim Mu-hun
0ed0799e23 docs: update the CONTRIBUTING.md (#230176)
* docs(contributing): fix branch naming convention

Documented `fix/123` didn't match actual team practice.
Real convention uses domain suffix: `fix-#{issue}-{domain}`.

* docs(contributing): add commit message format

Team uses `Fix #N domain` / `Upd #N domain` convention
but it wasn't documented for external contributors.

* docs(contributing): add rule placement conventions

Implicit team practices not previously documented:
new rules at section top, domain insertion at list
beginning/end, group consistency for same-domain rules.

* docs: update branch naming convention to slash-separated format

https://github.com/AdguardTeam/AdguardFilters/pull/230176#discussion_r3225315534

* docs: reword rule placement heading sentence

https://github.com/AdguardTeam/AdguardFilters/pull/230176#discussion_r3225834464

* docs: clarify same-domain group insertion wording

https://github.com/AdguardTeam/AdguardFilters/pull/230176#discussion_r3225858467

* docs: add group comment to same-domain code example

https://github.com/AdguardTeam/AdguardFilters/pull/230176#discussion_r3225881989

* docs: bold "beginning" and "at the end" separately

https://github.com/AdguardTeam/AdguardFilters/pull/230176#discussion_r3225964987

* docs: replace separate examples with combined mixed-type diff

https://github.com/AdguardTeam/AdguardFilters/pull/230176#discussion_r3226023924

* docs: remove label instruction

Regular users can't change the label: https://github.com/AdguardTeam/AdguardFilters/pull/230176#discussion_r3226041465

* docs: restructure mixed-type rule placement example

Moves the combined mixed-type diff after the type-specific examples
so readers see the individual rules first, then the override.
Adds a brief reason: only the separator differs (`,` vs `|`),
so consistent ordering makes missing domains immediately visible.

https://github.com/AdguardTeam/AdguardFilters/pull/230176#discussion_r3233231097

* docs: clarify fix vs upd branch prefix distinction

https://github.com/AdguardTeam/AdguardFilters/pull/230176#discussion_r3233187977

* docs: tighten same-rule-expression domain placement bullet

Prevents contributors from adding the domain as a new rule
on a separate line by making the instruction explicit.

https://github.com/AdguardTeam/AdguardFilters/pull/230176#discussion_r3233231097

* better without "or follow-ups"

Co-authored-by: Alex <alex302@adguard.com>

* If the rule applies to a site for which a rules group exists...

Co-authored-by: Alex <alex302@adguard.com>

* Add "depending on the type of rule"

Co-authored-by: Alex <alex302@adguard.com>

* For "cosmetic" rules

Co-authored-by: Alex <alex302@adguard.com>

* Update CONTRIBUTING.md

Co-authored-by: Alex <alex302@adguard.com>

* Update CONTRIBUTING.md

Co-authored-by: Alex <alex302@adguard.com>

* Update CONTRIBUTING.md

Co-authored-by: Alex <alex302@adguard.com>

* Remove the avoid notice

Co-authored-by: Alex <alex302@adguard.com>

* moved above

Co-authored-by: Alex <alex302@adguard.com>

* Update CONTRIBUTING.md

Co-authored-by: Alex <alex302@adguard.com>

* Update CONTRIBUTING.md

Co-authored-by: Alex <alex302@adguard.com>

* Update CONTRIBUTING.md

Co-authored-by: Alex <alex302@adguard.com>

* Fixed linter warnings

---------

Co-authored-by: Alex <alex302@adguard.com>
2026-05-15 00:54:51 +03:00
Anastasiia Fedotova
926ba81ca2 Add the filter policy link to the Knowledge Base (#227299)
* Add the filter policy link to the Knowledge Base

* lint fixes

* lint fix

* lint fix3
2026-03-23 11:59:34 +02:00
David
b9b379022a Migrate from Yarn to npm package manager and update AGLint to v3 (#205942)
* migrate from Yarn to npm package manager and update dependencies

* update CODEOWNERS file with new ownership assignments and reorder entries
2025-05-21 18:25:57 +03:00
Alex-302
310fd2fec9 Mv3 => MV3 2024-08-27 16:35:18 +03:00
Alex-302
1901ffcee5 Added AdGuard Quick Fixes filter 2024-08-27 12:25:22 +03:00
David
18350bfa68 Improve contributing guide (#176624) 2024-04-09 15:26:37 +03:00
Alex
87a89f9e9c Upd CONTRIBUTING.md (#175428) 2024-03-21 13:17:46 +02:00
Alex
bd0a4ca895 Fix md (#171934)
* Fix md

* upd
2024-01-31 22:17:58 +02:00
scripthunter7
b7e0b81a17 More detailed prepare instructions (#149292)
* More detailed prepare instructions

* fix width

* fix wording

* Update CONTRIBUTING.md

Co-authored-by: Alex <alex302@adguard.com>

* Update CONTRIBUTING.md

Co-authored-by: Alex <alex302@adguard.com>

* Update CONTRIBUTING.md

Co-authored-by: Alex <alex302@adguard.com>

---------

Co-authored-by: Alex <alex302@adguard.com>
2023-04-26 09:45:24 +03:00
Andrey Meshkov
39ed2ef297 Added a pre-commit hook that runs AGLint and validates filters.
Also, updated the documentation to explain how to set up the
repo properly.
2023-04-25 11:11:41 +03:00
Alex
f6a3e5df48 Renamed EnglishFilter to BaseFilter (#129688) 2022-09-14 16:32:23 +03:00
jellizaveta
c42c9ac271 Added info about splitted Annoyances filter (#124043)
* Added info about splitted Annoyances filter

* added fixes

* added styles

* added styles for description

* Update CONTRIBUTING.md

Co-authored-by: Alex <alex302@adguard.com>

* Update CONTRIBUTING.md

Co-authored-by: Alex <alex302@adguard.com>

* Update CONTRIBUTING.md

Co-authored-by: Slava <45171506+slavaleleka@users.noreply.github.com>

Co-authored-by: zloyden <33488229+zloyden@users.noreply.github.com>
Co-authored-by: Adam <adam@adguard.com>
Co-authored-by: Alex302 <alex302@adguard.com>
Co-authored-by: Slava Leleka <v.leleka@adguard.com>
Co-authored-by: ss-orlova <s.orlova@adguard.com>
Co-authored-by: Vasily Bagirov <vbagirov@adguard.com>
Co-authored-by: Andrey Meshkov <am@adguard.com>
2022-07-19 12:52:16 +03:00
Morku
dbfbf4dedb Copypaste fix (#110441)
Fix for mistake French -> German in describtion

Co-authored-by: zloyden <33488229+zloyden@users.noreply.github.com>
2022-02-14 17:51:37 +03:00
zloyden
640d0ca30c New repository documentation - contributing md file (#107224)
* Added a contibuting md file

* changed the place of the link to another word

* changed p4 in how to work with this repo

* removed en part from the links

* also mentioned two filters in the notes

* English - small fix

* English - made corrections as suggested

* English - correction about requirements

* English - correction about purpose

* English - correction p4

* English - reverted which

* English - made corrections as suggested p2

* added other AdGuard filters

* English - changed some descriptions

* English - changed the name of TrackParam filter, fix the purpose

* Structure and English - made corrections p3

* English - changed the title of the usefuladsfilter

Co-authored-by: Adam <adam@adguard.com>
Co-authored-by: Yuki2718 <58900598+Yuki2718@users.noreply.github.com>
Co-authored-by: Vasily Bagirov <vbagirov@adguard.com>
Co-authored-by: Alex302 <alex302@adguard.com>
Co-authored-by: Anastasiia Fedotova <a.fedotova@adguard.com>
Co-authored-by: Andrey Meshkov <am@adguard.com>
Co-authored-by: zloyden <33488229+zloyden@users.noreply.github.com>
2022-01-25 14:12:40 +03:00